Repository navigation
Add an opt-in V2 scan builder and execution path - #10302
Open
joseph-isaacs wants to merge 4 commits into
Open
joseph-isaacs wants to merge 4 commits into
joseph-isaacs wants to merge 4 commits into
Conversation
Copy the current scan builder and repeated scan into scan::v2, and select that path in DuckDB and DataFusion with VORTEX_SCAN_V2=1. Transfer every configured builder option when switching paths. Keep the existing split tasks so the new planning protocol and executor can land incrementally. Include scan parity and configuration-transfer tests. Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk>
Apply nightly-2026-09-10 formatting to the new scan tests. DCO Remediation Commit for Joe Isaacs <joe.isaacs@live.co.uk> I, Joe Isaacs <joe.isaacs@live.co.uk>, hereby add my Signed-off-by to this commit: ddd623d Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Current develop's Cargo.lock links three OpenDAL packages to asyncband 0.7.2, but Cargo resolves them to the already-locked 0.7.3. Regenerate those dependency edges with Cargo so --locked CI commands can run. Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will not alter performance
|
Remove ScanParts and into_parts once the V2 migration is complete. Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a separate V2 scan builder and an opt-in branch in DuckDB and DataFusion so the new scan implementation can land incrementally. With
VORTEX_SCAN_V2=1, both engines usevortex_layout::scan::v2::ScanBuilder; otherwise they keep their current path. The flag is read once per process.This PR targets
developdirectly and can merge independently of the protocol stack (#10047, #10048, #10049). It establishes the structure for follow-on planner, execution graph, and IO changes. It does not yet execute scans through the new planning protocol.Changes
scan::v2, retaining the existing split tasks for initial behavior parity.ScanBuilder::from_defaultand a crate-private configuration transfer that moves every builder option, including selection, natural splits, ordering, concurrency, mapping, limits, and row offsets.Validation: the initial CI run passed Rust builds and tests, SQL logic tests, and Clippy; the formatting differences in the new tests are fixed with
nightly-2026-09-10. DCO now passes. The first S3 run failed during RustFS bucket setup; service startup passed on retry. A later run exposed the same stale OpenDAL dependency edges indevelop's lockfile, so this branch includes currentdevelopand Cargo's three-entry lockfile repair.cargo metadata --locked --format-version 1, scoped formatting, andgit diff --checkpass locally. CI is rerunning on the updated branch.